Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3281)

Unified Diff: chrome/browser/ui/gtk/avatar_menu_item_gtk.cc

Issue 8933005: Linux/Gtk: Setting "can-focus" to FALSE for edit link in avatar menu. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/avatar_menu_item_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/avatar_menu_item_gtk.cc (revision 114211)
+++ chrome/browser/ui/gtk/avatar_menu_item_gtk.cc (working copy)
@@ -294,6 +294,10 @@
// The "edit your profile" link.
edit_profile_link_ = gtk_chrome_link_button_new(
l10n_util::GetStringUTF8(IDS_PROFILES_EDIT_PROFILE_LINK).c_str());
+ // Fix for bug#107348. edit link steals focus from menu item which
+ // hides edit link button in focus-out-event handler,
+ // so, it misses the click event.
+ gtk_widget_set_can_focus(edit_profile_link_, FALSE);
link_alignment_ = gtk_alignment_new(0, 0, 0, 0);
gtk_container_add(GTK_CONTAINER(link_alignment_), edit_profile_link_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698