Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/browser/ui/webui/sync_promo_trial.h

Issue 8933003: [Sync Promo UI] Changing sync promo to honor brand codes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some code review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo_trial.h
diff --git a/chrome/browser/ui/webui/sync_promo_trial.h b/chrome/browser/ui/webui/sync_promo_trial.h
index 5186bb53e75c193a4570ef2decf67731f8ea18c7..536ea859fd9b7fc298f1500b115965dec739bab0 100644
--- a/chrome/browser/ui/webui/sync_promo_trial.h
+++ b/chrome/browser/ui/webui/sync_promo_trial.h
@@ -30,6 +30,14 @@ namespace sync_promo_trial {
PROMO_MSG_MAX,
};
+ enum SyncPromoAndDefaultAppsCombination {
+ WITH_SYNC_PROMO_WITH_DEFAULT_APPS = 0,
+ WITH_SYNC_PROMO_WITHOUT_DEFAULT_APPS,
+ WITHOUT_SYNC_PROMO_WITH_DEFAULT_APPS,
+ WITHOUT_SYNC_PROMO_WITHOUT_DEFAULT_APPS,
+ SYNC_PROMO_AND_DEFAULT_APPS_BOUNDARY,
+ };
+
// Activate the field trial. Before this call, all calls to GetGroup will
// return PROMO_MSG_A. *** MUST NOT BE CALLED MORE THAN ONCE. ***
void Activate();
@@ -38,6 +46,10 @@ namespace sync_promo_trial {
// is false, the caller should not record stats for this experiment.
bool IsExperimentActive();
+ // If the user has been tagged with a brand code at install time that
+ // determines if they should see the sync promo or not.
+ bool IsPartOfBrandTrialToEnable();
+
// Return the field trial group this client belongs to.
Group GetGroup();
@@ -49,9 +61,23 @@ namespace sync_promo_trial {
// message.
void RecordUserSawMessage();
+ // Record that a user was shown the promo when tagged with an experimental
+ // brand code.
+ void RecordUserShownPromoWithTrialBrand();
+
// Record the appropriate UMA stat for when a user successfully signs in to
// GAIA.
void RecordUserSignedIn();
+
+ // Record that a user signed in while tagged with a brand code currently being
+ // used in a field trial.
+ void RecordUserSignedInWithTrialBrand();
+
+ // If we've been tagged with any of the experimental brands to show the sync
+ // promo.
+ bool ShouldShowAtStartupBasedOnBrand();
}
+extern const char kSyncPromoEnabledTrialName;
+
#endif // CHROME_BROWSER_UI_WEBUI_SYNC_PROMO_TRIAL_H_

Powered by Google App Engine
This is Rietveld 408576698