Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2921)

Unified Diff: chrome/browser/ui/webui/sync_promo_handler.cc

Issue 8933003: [Sync Promo UI] Changing sync promo to honor brand codes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some code review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/sync_promo_handler.cc
diff --git a/chrome/browser/ui/webui/sync_promo_handler.cc b/chrome/browser/ui/webui/sync_promo_handler.cc
index c2fb5689ecfafa0fcd87b0e252acccd1d541c37f..80b0ee0516390da3affb90c35188d2a818172e48 100644
--- a/chrome/browser/ui/webui/sync_promo_handler.cc
+++ b/chrome/browser/ui/webui/sync_promo_handler.cc
@@ -57,6 +57,13 @@ static bool IsValidUserFlowAction(int action) {
action == SYNC_PROMO_LEFT_DURING_THROBBER;
}
+static void RecordExperimentOutcomesOnSignIn() {
+ if (sync_promo_trial::IsExperimentActive())
+ sync_promo_trial::RecordUserSignedIn();
+ if (sync_promo_trial::IsPartOfBrandTrialToEnable())
+ sync_promo_trial::RecordUserSignedInWithTrialBrand();
+}
+
} // namespace
SyncPromoHandler::SyncPromoHandler(ProfileManager* profile_manager)
@@ -122,16 +129,12 @@ void SyncPromoHandler::RegisterMessages() {
}
void SyncPromoHandler::ShowGaiaSuccessAndClose() {
- if (sync_promo_trial::IsExperimentActive())
- sync_promo_trial::RecordUserSignedIn();
-
+ RecordExperimentOutcomesOnSignIn();
SyncSetupHandler::ShowGaiaSuccessAndClose();
}
void SyncPromoHandler::ShowGaiaSuccessAndSettingUp() {
- if (sync_promo_trial::IsExperimentActive())
- sync_promo_trial::RecordUserSignedIn();
-
+ RecordExperimentOutcomesOnSignIn();
SyncSetupHandler::ShowGaiaSuccessAndSettingUp();
}
« no previous file with comments | « no previous file | chrome/browser/ui/webui/sync_promo_trial.h » ('j') | chrome/browser/ui/webui/sync_promo_trial.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698