WebUI Task manager: prevent to kill the wrong process or none

WebUI Task manager: prevent to kill the wrong process or none 

Use the unique_id to determine the process instead of the selected index. 

BUG=chromium-os:23739
TEST=manual on chromium-os(aura) on Linux 

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114479

[yoshiki, 2011-12-13 08:40:27]

@mazda for review and @jhawkins for approval.

[James Hawkins, 2011-12-13 17:44:21]

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
File chrome/browser/ui/webui/task_manager_handler.cc (right):

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
chrome/browser/ui/webui/task_manager_handler.cc:345: for (int resource_index =
0; resource_index < model_->ResourceCount();
Is there not a better way to do this?  It seems like there should be a way to
KillProcess(pid).

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
chrome/browser/ui/webui/task_manager_handler.cc:356: LOG(INFO) << "kill PID:" <<
pid;
Remove log spam.

[yoshiki, 2011-12-14 09:06:47]

jhawkins: PATL?

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
File chrome/browser/ui/webui/task_manager_handler.cc (right):

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
chrome/browser/ui/webui/task_manager_handler.cc:345: for (int resource_index =
0; resource_index < model_->ResourceCount();
I changed to use unique_id to determine the process instead of pid. This is same
way as the other manipulate methods (HandleActivatePage() and HandleInspect()).
I think it is safer way to determine the process, because there are no
confidence to be able to convert "PID" into "int" without degradation on any
platform.

On 2011/12/13 17:44:22, James Hawkins wrote:
> Is there not a better way to do this?  It seems like there should be a way to
> KillProcess(pid).

http://codereview.chromium.org/8932003/diff/1/chrome/browser/ui/webui/task_ma...
chrome/browser/ui/webui/task_manager_handler.cc:356: LOG(INFO) << "kill PID:" <<
pid;
On 2011/12/13 17:44:22, James Hawkins wrote:
> Remove log spam.

Done.

[mazda, 2011-12-14 09:38:20]

lgtm with a nit.

http://codereview.chromium.org/8932003/diff/10001/chrome/browser/task_manager...
File chrome/browser/task_manager/task_manager.h (right):

http://codereview.chromium.org/8932003/diff/10001/chrome/browser/task_manager...
chrome/browser/task_manager/task_manager.h:276: int
GetResourceIndexByUniqueId(const int unique_id) const;
Please add a comment on the case where the index is not found.

[yoshiki, 2011-12-14 09:52:24]

mazda: thanks!

jhawkins: PTAL?

http://codereview.chromium.org/8932003/diff/10001/chrome/browser/task_manager...
File chrome/browser/task_manager/task_manager.h (right):

http://codereview.chromium.org/8932003/diff/10001/chrome/browser/task_manager...
chrome/browser/task_manager/task_manager.h:276: int
GetResourceIndexByUniqueId(const int unique_id) const;
On 2011/12/14 09:38:20, mazda wrote:
> Please add a comment on the case where the index is not found.

Done.

[James Hawkins, 2011-12-14 18:12:02]

lgtm

[commit-bot: I haz the power, 2011-12-14 18:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/8932003/6003

[commit-bot: I haz the power, 2011-12-14 19:41:38]

Change committed as 114479