Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/resources/task_manager/main.js

Issue 8932003: WebUI Task manager: prevent to kill the wrong process or none (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review fix Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/task_manager/task_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/task_manager/main.js
diff --git a/chrome/browser/resources/task_manager/main.js b/chrome/browser/resources/task_manager/main.js
index a4827dee1d7367eab63b7c69f359b3b97c8641f4..5c04529407d4988b041b23e1ded772ffee393f7a 100644
--- a/chrome/browser/resources/task_manager/main.js
+++ b/chrome/browser/resources/task_manager/main.js
@@ -85,12 +85,20 @@ TaskManager.prototype = {
},
/**
- * Sends commands to kill a process.
+ * Sends commands to kill selected processes.
* @public
*/
- killProcess: function () {
+ killSelectedProcesses: function () {
var selectedIndexes = this.selectionModel_.selectedIndexes;
- chrome.send('killProcess', selectedIndexes);
+ var dm = this.dataModel_;
+ var uniqueIds = [];
+ for (var i = 0; i < selectedIndexes.length; i++) {
+ var index = selectedIndexes[i];
+ var task = dm.item(index);
+ uniqueIds.push(task['uniqueId'][0]);
+ }
+
+ chrome.send('killProcesses', uniqueIds);
},
/**
@@ -152,7 +160,8 @@ TaskManager.prototype = {
this.document_ = dialogDom.ownerDocument;
$('close-window').addEventListener('click', this.close.bind(this));
- $('kill-process').addEventListener('click', this.killProcess.bind(this));
+ $('kill-process').addEventListener('click',
+ this.killSelectedProcesses.bind(this));
$('about-memory-link').addEventListener('click',
this.openAboutMemory.bind(this));
« no previous file with comments | « no previous file | chrome/browser/task_manager/task_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698