Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 8932001: Update widget size from StatusAreaView::Layout() (Closed)

Created:
9 years ago by stevenjb
Modified:
8 years, 12 months ago
Reviewers:
Nikita (slow), sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Update widget size from StatusAreaView::Layout() Change-Id: I461b53554bb67f6fe9681d04940e2131e2a9224c BUG=107309 TEST=See issue Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114501

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move GetWidget()->SetSize() -> PreferredSizeChanged() #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/chromeos/status/status_area_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_view.cc View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
stevenjb
If we only call GetWidget()->SetSize() from ChildPreferredSizeChanged(), we won't catch size changes due to visibility ...
9 years ago (2011-12-13 02:29:02 UTC) #1
sky
http://codereview.chromium.org/8932001/diff/1/chrome/browser/chromeos/status/status_area_view.cc File chrome/browser/chromeos/status/status_area_view.cc (right): http://codereview.chromium.org/8932001/diff/1/chrome/browser/chromeos/status/status_area_view.cc#newcode92 chrome/browser/chromeos/status/status_area_view.cc:92: if (GetWidget()) This makes it easy to get stuck ...
9 years ago (2011-12-13 16:40:41 UTC) #2
stevenjb
http://codereview.chromium.org/8932001/diff/1/chrome/browser/chromeos/status/status_area_view.cc File chrome/browser/chromeos/status/status_area_view.cc (right): http://codereview.chromium.org/8932001/diff/1/chrome/browser/chromeos/status/status_area_view.cc#newcode92 chrome/browser/chromeos/status/status_area_view.cc:92: if (GetWidget()) On 2011/12/13 16:40:41, sky wrote: > This ...
9 years ago (2011-12-14 02:10:51 UTC) #3
sky
LGTM
9 years ago (2011-12-14 15:33:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8932001/12001
9 years ago (2011-12-14 20:26:35 UTC) #5
commit-bot: I haz the power
Change committed as 114501
9 years ago (2011-12-14 22:13:00 UTC) #6
Nikita (slow)
8 years, 12 months ago (2011-12-26 10:44:53 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698