Update widget size from StatusAreaView::Layout()

chrome/browser/chromeos/status/status_area_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/status/status_area_view.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 70 matching lines @@
       int cur_y = (height() - cur_size.height()) / 2;
 
       // Handle odd number of pixels.
       cur_y += (height() - cur_size.height()) % 2;
 
       // Put next in row horizontally, and center vertically.
       cur->SetBounds(cur_x, cur_y, cur_size.width(), cur_size.height());
       cur_x += cur_size.width() + kSeparation;
     }
   }
+#if defined(USE_AURA)
+  if (GetWidget())

[sky, 2011/12/13 16:40:41]

This makes it easy to get stuck in a loop. Can we instead invoke
PreferredSizeChanged when toggling visibility?

[stevenjb, 2011/12/14 02:10:51]

We already do; I will override PreferredSizeChanged() and move this chunk of
code there.
Done.

+    GetWidget()->SetSize(GetPreferredSize());
+#endif
 }
 
 void StatusAreaView::ChildPreferredSizeChanged(View* child) {
   // When something like the clock menu button's size changes, we need to
   // relayout. Also mark that this view's size has changed. This will let
   // BrowserView know to relayout, which will reset the bounds of this view.
   Layout();
   PreferredSizeChanged();
-#if defined(USE_AURA)
-  if (GetWidget())
-    GetWidget()->SetSize(GetPreferredSize());
-#endif
 }
 
 void StatusAreaView::MakeButtonsActive(bool active) {
   for (std::list<StatusAreaButton*>::iterator iter = buttons_.begin();
        iter != buttons_.end(); ++iter) {
     (*iter)->set_menu_active(active);
   }
 }
 
 void StatusAreaView::UpdateButtonVisibility() {
@@ skipping 32 matching lines @@
   if (need_return_focus_) {
     const views::View* first = GetFirstFocusableChild();
     const views::View* last = GetLastFocusableChild();
     const bool first_to_last = (focused_before == first && focused_now == last);
     const bool last_to_first = (focused_now == first && focused_before == last);
 
     if (first_to_last || last_to_first)
       ReturnFocus(first_to_last);
   }
 }