tools/testing/dart/test_suite.dart - Issue 8931027: Fix read handler bug in tools/test.dart: Replace dataHandler with lineHandler if using readLine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 8931027: Fix read handler bug in tools/test.dart: Replace dataHandler with lineHandler if using readLine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index a2e4947210f3a7568472ec9af86fb02d9dde08ef..67f7a40a383fd4eeb28485f1c6282c18ed5a8309 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -23,7 +23,7 @@ class CCTestListerIsolate extends Isolate {

var p = new Process(runnerPath, ["--list"]);

StringInputStream stdoutStream = new StringInputStream(p.stdout);

List<String> tests = new List<String>();

- stdoutStream.dataHandler = () {

+ stdoutStream.lineHandler = () {

String line = stdoutStream.readLine();

while (line != null) {

tests.add(line);

« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »