Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8931027: Fix read handler bug in tools/test.dart: Replace dataHandler with lineHandler if using readLine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index b4c2c2f8c5d262f8df0a53419fb25bfb15cb4e39..b582a55376cc8cfaf77fac4b05cee27d067ea3d6 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -232,9 +232,9 @@ class RunningProcess {
InputStream stderrStream = process.stderr;
StringInputStream stdoutStringStream = new StringInputStream(stdoutStream);
StringInputStream stderrStringStream = new StringInputStream(stderrStream);
- stdoutStringStream.dataHandler =
+ stdoutStringStream.lineHandler =
makeReadHandler(stdoutStringStream, stdout);
- stderrStringStream.dataHandler =
+ stderrStringStream.lineHandler =
makeReadHandler(stderrStringStream, stderr);
timeoutTimer = new Timer(timeoutHandler, 1000 * testCase.timeout, false);
}
@@ -292,8 +292,8 @@ class DartcBatchRunnerProcess {
_startTime = new Date.now();
_testStdout = new List<String>();
_testStderr = new List<String>();
- _stdoutStream.dataHandler = _readOutput(_stdoutStream, _testStdout);
- _stderrStream.dataHandler = _readOutput(_stderrStream, _testStderr);
+ _stdoutStream.lineHandler = _readOutput(_stdoutStream, _testStdout);
+ _stderrStream.lineHandler = _readOutput(_stderrStream, _testStderr);
_timer = new Timer(_timeoutHandler(testCase),
testCase.timeout * 1000,
false);
@@ -369,8 +369,8 @@ class DartcBatchRunnerProcess {
_stderrStream = new StringInputStream(_process.stderr);
_testStdout = new List<String>();
_testStderr = new List<String>();
- _stdoutStream.dataHandler = _readOutput(_stdoutStream, _testStdout);
- _stderrStream.dataHandler = _readOutput(_stderrStream, _testStderr);
+ _stdoutStream.lineHandler = _readOutput(_stdoutStream, _testStdout);
+ _stderrStream.lineHandler = _readOutput(_stderrStream, _testStderr);
_process.exitHandler = _exitHandler;
_process.start();
}
« no previous file with comments | « no previous file | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698