Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 8931026: Reverting because I reverted the CL this depends on... (Closed)

Created:
9 years ago by Finnur
Modified:
9 years ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews
Visibility:
Public.

Description

Reverting because I reverted the CL this depends on... Revert 114389 - WebSocket Pepper API: Add live object check to WebSocket PPAPI tests - Add RUN_TEST_WITH_REFERENCE_CHECK macro which run a test then check leaked pepper objects. - Use that macro to run all WebSocket related PPAPI unit tests - Fix some object leak in tests found by the macro BUG=87310 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*' Review URL: http://codereview.chromium.org/8934003 TBR=toyoshim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -33 lines) Patch
M ppapi/tests/test_case.h View 1 chunk +0 lines, -14 lines 0 comments Download
M ppapi/tests/test_websocket.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_websocket.cc View 4 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Finnur
9 years ago (2011-12-14 10:19:42 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698