Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 8934003: WebSocket Pepper API: Add live object check to WebSocket PPAPI tests (Closed)

Created:
9 years ago by Takashi Toyoshima
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Reland; WebSocket Pepper API: Add live object check to WebSocket PPAPI tests - Add RUN_TEST_WITH_REFERENCE_CHECK macro which run a test then check leaked pepper objects. - Use that macro to run all WebSocket related PPAPI unit tests - Fix some object leak in tests found by the macro BUG=87310 TEST=ui_tests --gtest_filter='PPAPITest.WebSocket_*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114389 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114604

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -12 lines) Patch
M ppapi/tests/test_case.h View 1 chunk +14 lines, -0 lines 0 comments Download
M ppapi/tests/test_websocket.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_websocket.cc View 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Takashi Toyoshima
Hi pepper guys, I split this change from Var/VarTracker reference counting issue. In the discussion, ...
9 years ago (2011-12-13 12:11:59 UTC) #1
brettw
lgtm
9 years ago (2011-12-13 15:16:29 UTC) #2
dmichael (off chromium)
lgtm
9 years ago (2011-12-13 16:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8934003/1
9 years ago (2011-12-14 03:44:33 UTC) #4
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-14 06:02:55 UTC) #5
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-12-14 06:37:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8934003/4003
9 years ago (2011-12-14 14:47:51 UTC) #7
Takashi Toyoshima
must be landed after a reverted bug fix. reset the CQ flag.
9 years ago (2011-12-14 14:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8934003/4003
9 years ago (2011-12-15 05:25:45 UTC) #9
commit-bot: I haz the power
9 years ago (2011-12-15 06:43:13 UTC) #10
Change committed as 114604

Powered by Google App Engine
This is Rietveld 408576698