Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 8930019: Use a shorter include paths on Windows. (Closed)

Created:
9 years ago by tony
Modified:
9 years ago
Reviewers:
M-A Ruel, dglazkov
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Use a shorter include paths on Windows. We were hitting the MAXPATH limit on the build.webkit.org win bots. BUG=webkit.org/b/74320 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114686

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webkit/support/setup_third_party.py View 1 chunk +9 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
tony
9 years ago (2011-12-13 22:03:20 UTC) #1
dglazkov
lgtm
9 years ago (2011-12-15 01:16:11 UTC) #2
M-A Ruel
(I don't really mind, still lgtm) (Sorry I missed it) http://codereview.chromium.org/8930019/diff/1/webkit/support/setup_third_party.py File webkit/support/setup_third_party.py (right): http://codereview.chromium.org/8930019/diff/1/webkit/support/setup_third_party.py#newcode107 ...
9 years ago (2011-12-15 01:19:37 UTC) #3
tony
On 2011/12/15 01:19:37, Marc-Antoine Ruel wrote: > http://codereview.chromium.org/8930019/diff/1/webkit/support/setup_third_party.py > File webkit/support/setup_third_party.py (right): > > http://codereview.chromium.org/8930019/diff/1/webkit/support/setup_third_party.py#newcode107 ...
9 years ago (2011-12-15 17:56:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/8930019/1
9 years ago (2011-12-15 17:57:15 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-15 19:56:02 UTC) #6
Change committed as 114686

Powered by Google App Engine
This is Rietveld 408576698