Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Unified Diff: webkit/support/setup_third_party.py

Issue 8930019: Use a shorter include paths on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/setup_third_party.py
diff --git a/webkit/support/setup_third_party.py b/webkit/support/setup_third_party.py
index f3cf719c5b8590eec9cc83a7bc2baad9201f0185..61003d149fd154558c22c91c1bd23fb20edc7d31 100644
--- a/webkit/support/setup_third_party.py
+++ b/webkit/support/setup_third_party.py
@@ -103,8 +103,15 @@ def WriteSetupFilename(input_filename, out_filename):
num_parent_dirs += 1
out_dir = os.path.split(out_dir)[0]
- rel_path = os.path.join('/'.join(['..'] * num_parent_dirs),
- input_filename[len(ancestor):])
+ if sys.platform == 'win32':
+ # Windows has a file path limit of 260 characters that we can hit when
M-A Ruel 2011/12/15 01:19:37 Why not do the same on all platforms?
+ # generating these forwarding headers. Instead of writing the full
+ # relative path, just write the path relative to the WebKit/chromium dir,
+ # which is in the include path.
+ rel_path = input_filename[len(ancestor):]
+ else:
+ rel_path = os.path.join('/'.join(['..'] * num_parent_dirs),
+ input_filename[len(ancestor):])
out_file = open(out_filename, 'w')
out_file.write("""// This file is generated. Do not edit.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698