Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 8930002: Enforce cwd for GIT functions (Closed)

Created:
9 years ago by M-A Ruel
Modified:
9 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Enforce cwd for GIT functions GIT.CaptureStatus was assuming os.getcwd() was using all the time, which isn't true when using trychange.py --sub_rep XXX. R=dpranke@chromium.org TEST= BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M git_cl.py View 1 chunk +1 line, -1 line 0 comments Download
M git_try.py View 2 chunks +5 lines, -3 lines 0 comments Download
M scm.py View 5 chunks +10 lines, -9 lines 0 comments Download
M trychange.py View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years ago (2011-12-13 02:30:25 UTC) #1
Dirk Pranke
lgtm
9 years ago (2011-12-13 02:55:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8930002/1
9 years ago (2011-12-13 20:37:10 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 20:44:12 UTC) #4
Change committed as 114264

Powered by Google App Engine
This is Rietveld 408576698