Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: scm.py

Issue 8930002: Enforce cwd for GIT functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_try.py ('k') | trychange.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scm.py
diff --git a/scm.py b/scm.py
index 56e795fcfecbd9f35fbcc9d67f24eed2f6cb9477..b1f2e653e91a50429c1324080bc9a15c9a3e1053 100644
--- a/scm.py
+++ b/scm.py
@@ -97,19 +97,19 @@ class GIT(object):
current_version = None
@staticmethod
- def Capture(args, **kwargs):
+ def Capture(args, cwd, **kwargs):
return subprocess2.check_output(
- ['git'] + args, stderr=subprocess2.PIPE, **kwargs)
+ ['git'] + args, cwd=cwd, stderr=subprocess2.PIPE, **kwargs)
@staticmethod
- def CaptureStatus(files, upstream_branch=None):
+ def CaptureStatus(files, cwd, upstream_branch):
"""Returns git status.
@files can be a string (one file) or a list of files.
Returns an array of (status, file) tuples."""
if upstream_branch is None:
- upstream_branch = GIT.GetUpstreamBranch(os.getcwd())
+ upstream_branch = GIT.GetUpstreamBranch(cwd)
if upstream_branch is None:
raise gclient_utils.Error('Cannot determine upstream branch')
command = ['diff', '--name-status', '-r', '%s...' % upstream_branch]
@@ -119,7 +119,7 @@ class GIT(object):
command.append(files)
else:
command.extend(files)
- status = GIT.Capture(command).rstrip()
+ status = GIT.Capture(command, cwd).rstrip()
results = []
if status:
for statusline in status.splitlines():
@@ -226,7 +226,7 @@ class GIT(object):
# pipe at a time.
# The -100 is an arbitrary limit so we don't search forever.
cmd = ['git', 'log', '-100', '--pretty=medium']
- proc = subprocess2.Popen(cmd, stdout=subprocess2.PIPE)
+ proc = subprocess2.Popen(cmd, cwd, stdout=subprocess2.PIPE)
url = None
for line in proc.stdout:
match = git_svn_re.match(line)
@@ -237,8 +237,9 @@ class GIT(object):
if url:
svn_remote_re = re.compile(r'^svn-remote\.([^.]+)\.url (.*)$')
- remotes = GIT.Capture(['config', '--get-regexp',
- r'^svn-remote\..*\.url'], cwd=cwd).splitlines()
+ remotes = GIT.Capture(
+ ['config', '--get-regexp', r'^svn-remote\..*\.url'],
+ cwd=cwd).splitlines()
for remote in remotes:
match = svn_remote_re.match(remote)
if match:
@@ -383,7 +384,7 @@ class GIT(object):
def AssertVersion(cls, min_version):
"""Asserts git's version is at least min_version."""
if cls.current_version is None:
- cls.current_version = cls.Capture(['--version']).split()[-1]
+ cls.current_version = cls.Capture(['--version'], '.').split()[-1]
current_version_list = map(only_int, cls.current_version.split('.'))
for min_ver in map(int, min_version.split('.')):
ver = current_version_list.pop(0)
« no previous file with comments | « git_try.py ('k') | trychange.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698