Issue 8929027: Follow-up changes to http://codereview.chromium.org/8937001

Issue 8929027: Follow-up changes to http://codereview.chromium.org/8937001 (Closed)

Created:
9 years ago by marja

Modified:
9 years ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Follow-up changes to http://codereview.chromium.org/8937001 Adding tests + minor code cleanup. BUG=NONE TEST=BrowserListTest.AttemptRestart, BrowserInitTest.ReadingWasRestartAfter(Restart|NormalStart) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114441 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114620

Patch Set 4 : Code review + test fix. #

Patch Set 5 : Disabling the AttemptRestart test on ChromiumOS. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -12 lines)			Patch
M	chrome/browser/ui/browser_init.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	1 2 3 4	2 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/browser_init_browsertest.cc	View	1 2 3 4	3 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_list_unittest.cc	View	1 2 3 4	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

marja

Hi, This CL contains the suggested follow-up changes to http://codereview.chromium.org/8937001 , please take a look.

9 years ago (2011-12-14 12:40:35 UTC) #1

sky

Thanks for doing this! LGTM with the name fix below. http://codereview.chromium.org/8929027/diff/10001/chrome/browser/ui/browser_init.cc File chrome/browser/ui/browser_init.cc (right): http://codereview.chromium.org/8929027/diff/10001/chrome/browser/ui/browser_init.cc#newcode590 ...

9 years ago (2011-12-14 15:22:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8929027/11005

9 years ago (2011-12-14 15:49:54 UTC) #3

marja

Thanks for comments! I committed this, but needed to revert, since the AttemptRestart test didn't ...

9 years ago (2011-12-15 09:21:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/8929027/19001

9 years ago (2011-12-15 09:23:50 UTC) #6

Change committed as 114620

Expand Messages | Collapse Messages