Follow-up changes to http://codereview.chromium.org/8937001

chrome/browser/ui/browser_init.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_init.h"
 
 #include <algorithm>   // For max().
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 480 matching lines @@
     g_browser_process->crl_set_fetcher()->StartInitialLoad(cus);
 
   cus->Start();
 }
 
 }  // namespace
 
 
 // BrowserInit ----------------------------------------------------------------
 
-bool BrowserInit::was_restarted_ = false;
-bool BrowserInit::was_restarted_read_ = false;
-
 BrowserInit::BrowserInit() {}
 
 BrowserInit::~BrowserInit() {}
 
 void BrowserInit::AddFirstRunTab(const GURL& url) {
   first_run_tabs_.push_back(url);
 }
 
 // static
 bool BrowserInit::InProcessStartup() {
@@ skipping 68 matching lines @@
         ->AddNetworkManagerObserver(sms_observer);
 
     profile->SetupChromeOSEnterpriseExtensionObserver();
   }
 #endif
   return true;
 }
 
 // static
 bool BrowserInit::WasRestarted() {
+  // Stores the value of the preference kWasRestarted had when it was read.
+  static bool was_restarted_ = false;

[sky, 2011/12/14 15:22:21]

Since you're moving these to locals, don't end them with '_'. Eg,
'was_restarted' here.

[marja, 2011/12/15 09:21:32]

Done.

+
+  // True if we have already read and reset the preference kWasRestarted.
+  static bool was_restarted_read_ = false;
+
   if (!was_restarted_read_) {
     PrefService* pref_service = g_browser_process->local_state();
     was_restarted_ = pref_service->GetBoolean(prefs::kWasRestarted);
     pref_service->SetBoolean(prefs::kWasRestarted, false);
     pref_service->ScheduleSavePersistentPrefs();
     was_restarted_read_ = true;
   }
   return was_restarted_;
 }
 
@@ skipping 936 matching lines @@
 
   Profile* profile = ProfileManager::GetLastUsedProfile();
   if (!profile) {
     // We should only be able to get here if the profile already exists and
     // has been created.
     NOTREACHED();
     return;
   }
   ProcessCmdLineImpl(cmd_line, cur_dir, false, profile, NULL, NULL);
 }