Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 8929022: reduce log verbosity level (Closed)

Created:
9 years ago by bsy
Modified:
9 years ago
CC:
chromium-reviews, Brad Chen (chromium)
Visibility:
Public.

Description

reduce log verbosity level Some NaClLog invocations were left with detail level 0, which gets printed by default. This CL just increases some of these, so that NACLVERBOSITY environment variable would have to be set to see events such as NaCl module crash log messages that occur while generating the 'crashed' event. BUG= None TEST= None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114585

Patch Set 1 #

Patch Set 2 : clarify exit vs crash #

Total comments: 2

Patch Set 3 : made logging detail levels match #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsy
Please take a look.
9 years ago (2011-12-15 01:34:12 UTC) #1
sehr (please use chromium)
LGTM with one nit. http://codereview.chromium.org/8929022/diff/3001/ppapi/native_client/src/trusted/plugin/service_runtime.cc File ppapi/native_client/src/trusted/plugin/service_runtime.cc (right): http://codereview.chromium.org/8929022/diff/3001/ppapi/native_client/src/trusted/plugin/service_runtime.cc#newcode370 ppapi/native_client/src/trusted/plugin/service_runtime.cc:370: NaClLog(4, change to match the ...
9 years ago (2011-12-15 01:37:51 UTC) #2
bsy
http://codereview.chromium.org/8929022/diff/3001/ppapi/native_client/src/trusted/plugin/service_runtime.cc File ppapi/native_client/src/trusted/plugin/service_runtime.cc (right): http://codereview.chromium.org/8929022/diff/3001/ppapi/native_client/src/trusted/plugin/service_runtime.cc#newcode370 ppapi/native_client/src/trusted/plugin/service_runtime.cc:370: NaClLog(4, On 2011/12/15 01:37:51, sehr wrote: > change to ...
9 years ago (2011-12-15 01:39:41 UTC) #3
sehr (please use chromium)
lgtm
9 years ago (2011-12-15 01:39:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bsy@google.com/8929022/11001
9 years ago (2011-12-15 01:39:51 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-15 02:53:40 UTC) #6
Change committed as 114585

Powered by Google App Engine
This is Rietveld 408576698