Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 8929022: reduce log verbosity level (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: made logging detail levels match Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/src/trusted/plugin/plugin.cc
diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc
index ce4ff1814f1d6414c07c84f8bfd36c8e03e22e26..7b9829782df44a45364629280068ab7a72a0af1e 100644
--- a/ppapi/native_client/src/trusted/plugin/plugin.cc
+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc
@@ -1275,6 +1275,15 @@ void Plugin::NexeDidCrash(int32_t pp_error) {
" non-PP_OK arg -- SHOULD NOT HAPPEN\n"));
}
PLUGIN_PRINTF(("Plugin::NexeDidCrash: crash event!\n"));
+ int exit_status = main_subprocess_.service_runtime()->exit_status();
+ if (-1 != exit_status) {
+ // The NaCl module voluntarily exited. However, this is still a
+ // crash from the point of view of Pepper, since PPAPI plugins are
+ // event handlers and should never exit.
+ PLUGIN_PRINTF((("Plugin::NexeDidCrash: nexe exited with status %d"
+ " so this is a \"controlled crash\".\n"),
+ exit_status));
+ }
// If the crash occurs during load, we just want to report an error
// that fits into our load progress event grammar. If the crash
// occurs after loaded/loadend, then we use ReportDeadNexe to send a
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/service_runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698