Issue 8923001: WebUI: fix error in Grid.getItemsInViewPort preventing correct layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8923001: WebUI: fix error in Grid.getItemsInViewPort preventing correct layout. (Closed)

Created:
9 years ago by Ivan Korotkov

Modified:
9 years ago

Reviewers:
yoshiki, James Hawkins, jhawkins

CC:
chromium-reviews, arv (Not doing code reviews), Nikita (slow)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

WebUI: fix error in Grid.getItemsInViewPort preventing correct layout. BUG=chromium-os:24015 TEST=Manual: see bug description; all grids in WebUI should be layout properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114279

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/grid.js	View		1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8923001/1

9 years ago (2011-12-12 18:22:47 UTC) #3

commit-bot: I haz the power

Presubmit check for 8923001-1 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-12-12 18:22:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8923001/1

9 years ago (2011-12-13 20:07:20 UTC) #7

Change committed as 114279