chrome/browser/resources/shared/js/cr/ui/grid.js - Issue 8923001: WebUI: fix error in Grid.getItemsInViewPort preventing correct layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/cr/ui/grid.js

Issue 8923001: WebUI: fix error in Grid.getItemsInViewPort preventing correct layout. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/cr/ui/grid.js

diff --git a/chrome/browser/resources/shared/js/cr/ui/grid.js b/chrome/browser/resources/shared/js/cr/ui/grid.js

index 30827ad89dfecac8941ea54a7d6333e8a3cbfc51..3d071c8d56cc5ea61d4ab1ee731d743d09cd1af5 100644

--- a/chrome/browser/resources/shared/js/cr/ui/grid.js

+++ b/chrome/browser/resources/shared/js/cr/ui/grid.js

@@ -168,7 +168,11 @@ cr.define('cr.ui', function() {

this.countItemsInRange_(firstIndex, scrollTop + clientHeight));

count = columns * Math.ceil(count / columns);

count = Math.min(count, this.dataModel.length - firstIndex);

- return count;

+ return {

+ first: firstIndex,

+ length: count,

+ last: firstIndex + count - 1

+ };

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »