Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 8921033: Implement revised factories in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« corelib/src/implementation/hash_map_set.dart ('K') | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 2391)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -2269,7 +2269,9 @@
while (outer_function.IsLocalFunction()) {
outer_function = outer_function.parent_function();
}
- if (outer_function.IsFactory()) {
+ // TODO(regis): Remove support for type parameters on factories.
+ if (outer_function.IsFactory() &&
+ (outer_function.signature_class() != Class::null())) {
instantiator_class = outer_function.signature_class();
} else {
instantiator_class = outer_function.owner();
« corelib/src/implementation/hash_map_set.dart ('K') | « runtime/vm/class_finalizer.cc ('k') | runtime/vm/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698