net/ftp/ftp_ctrl_response_buffer.cc - Issue 8921006: Standardize StringToInt{,64} interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_ctrl_response_buffer.cc

Issue 8921006: Standardize StringToInt{,64} interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Updated StringPiece constructor interface to use iterators. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/ftp/ftp_ctrl_response_buffer.cc

diff --git a/net/ftp/ftp_ctrl_response_buffer.cc b/net/ftp/ftp_ctrl_response_buffer.cc

index 4aeef1faa4380995f279db3a64f0332cb141f3d9..6e9b5ff843a107be93c3ba4b0a63b72512be6b44 100644

--- a/net/ftp/ftp_ctrl_response_buffer.cc

+++ b/net/ftp/ftp_ctrl_response_buffer.cc

@@ -6,9 +6,12 @@

#include "base/logging.h"

#include "base/string_number_conversions.h"

+#include "base/string_piece.h"

//#include "base/string_util.h"

#include "net/base/net_errors.h"

+using base::StringPiece;

namespace net {

// static

@@ -91,7 +94,8 @@ FtpCtrlResponseBuffer::ParsedLine FtpCtrlResponseBuffer::ParseLine(

ParsedLine result;

if (line.length() >= 3) {

- if (base::StringToInt(line.begin(), line.begin() + 3, &result.status_code))

+ if (base::StringToInt(StringPiece(line.begin(), line.begin() + 3),

+ &result.status_code))

result.has_status_code = (100 <= result.status_code &&

result.status_code <= 599);

if (result.has_status_code && line.length() >= 4 && line[3] == ' ') {