Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/base/net_util.cc

Issue 8921006: Standardize StringToInt{,64} interface. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Updated StringPiece constructor interface to use iterators. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/autocomplete_history_manager.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | net/base/x509_cert_types.cc » ('j') | net/http/http_response_headers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util.cc
diff --git a/net/base/net_util.cc b/net/base/net_util.cc
index 7ae4363d3b3778cb63fa6faa990def2c036d0723..f832b361c628f278a25451fce71d02dbef08f8ee 100644
--- a/net/base/net_util.cc
+++ b/net/base/net_util.cc
@@ -72,6 +72,7 @@
#include "unicode/uscript.h"
#include "unicode/uset.h"
+using base::StringPiece;
using base::Time;
namespace net {
@@ -1985,9 +1986,8 @@ void SetExplicitlyAllowedPorts(const std::string& allowed_ports) {
if (i == size || allowed_ports[i] == kComma) {
if (i > last) {
int port;
- base::StringToInt(allowed_ports.begin() + last,
- allowed_ports.begin() + i,
- &port);
+ base::StringToInt(StringPiece(allowed_ports.begin() + last,
+ allowed_ports.begin() + i), &port);
erikwright (departed) 2011/12/13 20:20:45 Wrapping.
ports.insert(port);
}
last = i + 1;
« chrome/browser/autocomplete_history_manager.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_blocking_page.cc ('k') | net/base/x509_cert_types.cc » ('j') | net/http/http_response_headers.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698