Standardize StringToInt{,64} interface.

net/base/net_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 
@@ skipping 54 matching lines @@
 #endif
 #include "unicode/datefmt.h"
 #include "unicode/regex.h"
 #include "unicode/ucnv.h"
 #include "unicode/uidna.h"
 #include "unicode/ulocdata.h"
 #include "unicode/uniset.h"
 #include "unicode/uscript.h"
 #include "unicode/uset.h"
 
+using base::StringPiece;
 using base::Time;
 
 namespace net {
 
 namespace {
 
 // what we prepend to get a file URL
 static const FilePath::CharType kFileURLPrefix[] =
     FILE_PATH_LITERAL("file:///");
 
@@ skipping 1893 matching lines @@
 
   // Overflow is still possible for evil user inputs.
   for (size_t i = 0; i <= size; ++i) {
     // The string should be composed of only digits and commas.
     if (i != size && !IsAsciiDigit(allowed_ports[i]) &&
         (allowed_ports[i] != kComma))
       return;
     if (i == size || allowed_ports[i] == kComma) {
       if (i > last) {
         int port;
-        base::StringToInt(allowed_ports.begin() + last,
-                          allowed_ports.begin() + i,
-                          &port);
+        base::StringToInt(StringPiece(allowed_ports.begin() + last,
+                                      allowed_ports.begin() + i), &port);

[erikwright (departed), 2011/12/13 20:20:45]

Wrapping.

         ports.insert(port);
       }
       last = i + 1;
     }
   }
   g_explicitly_allowed_ports.Get() = ports;
 }
 
 ScopedPortException::ScopedPortException(int port) : port_(port) {
   g_explicitly_allowed_ports.Get().insert(port);
@@ skipping 453 matching lines @@
 
 NetworkInterface::NetworkInterface(const std::string& name,
                                    const IPAddressNumber& address)
     : name(name), address(address) {
 }
 
 NetworkInterface::~NetworkInterface() {
 }
 
 }  // namespace net