Standardize StringToInt{,64} interface.

net/ftp/ftp_ctrl_response_buffer.cc

Index: net/ftp/ftp_ctrl_response_buffer.cc
diff --git a/net/ftp/ftp_ctrl_response_buffer.cc b/net/ftp/ftp_ctrl_response_buffer.cc
index 4aeef1faa4380995f279db3a64f0332cb141f3d9..6e9b5ff843a107be93c3ba4b0a63b72512be6b44 100644
--- a/net/ftp/ftp_ctrl_response_buffer.cc
+++ b/net/ftp/ftp_ctrl_response_buffer.cc
@@ -6,9 +6,12 @@
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
+#include "base/string_piece.h"
 //#include "base/string_util.h"
 #include "net/base/net_errors.h"
 
+using base::StringPiece;
+
 namespace net {
 
 // static
@@ -91,7 +94,8 @@ FtpCtrlResponseBuffer::ParsedLine FtpCtrlResponseBuffer::ParseLine(
   ParsedLine result;
 
   if (line.length() >= 3) {
-    if (base::StringToInt(line.begin(), line.begin() + 3, &result.status_code))
+    if (base::StringToInt(StringPiece(line.begin(), line.begin() + 3),

[cbentzel, 2011/12/14 16:54:09]

What would happen if you just passed in 3 here? Would the line.begin() get
implicitly converted to a const char* and call the const char*, len constructor?

I'm always wary about overloading for this reason, but it's a key point of the
StringPiece class.

+                          &result.status_code))
       result.has_status_code = (100 <= result.status_code &&
                                 result.status_code <= 599);
     if (result.has_status_code && line.length() >= 4 && line[3] == ' ') {