Standardize StringToInt{,64} interface.

net/ftp/ftp_ctrl_response_buffer.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.  Use of this
 // source code is governed by a BSD-style license that can be found in the
 // LICENSE file.
 
 #include "net/ftp/ftp_ctrl_response_buffer.h"
 
 #include "base/logging.h"
 #include "base/string_number_conversions.h"
+#include "base/string_piece.h"
 //#include "base/string_util.h"
 #include "net/base/net_errors.h"
 
+using base::StringPiece;
+
 namespace net {
 
 // static
 const int FtpCtrlResponse::kInvalidStatusCode = -1;
 
 FtpCtrlResponse::FtpCtrlResponse() : status_code(kInvalidStatusCode) {}
 
 FtpCtrlResponse::~FtpCtrlResponse() {}
 
 FtpCtrlResponseBuffer::FtpCtrlResponseBuffer() : multiline_(false) {}
@@ skipping 62 matching lines @@
       is_complete(false),
       status_code(FtpCtrlResponse::kInvalidStatusCode) {
 }
 
 // static
 FtpCtrlResponseBuffer::ParsedLine FtpCtrlResponseBuffer::ParseLine(
     const std::string& line) {
   ParsedLine result;
 
   if (line.length() >= 3) {
-    if (base::StringToInt(line.begin(), line.begin() + 3, &result.status_code))
+    if (base::StringToInt(StringPiece(line.begin(), line.begin() + 3),

[cbentzel, 2011/12/14 16:54:09]

What would happen if you just passed in 3 here? Would the line.begin() get
implicitly converted to a const char* and call the const char*, len constructor?

I'm always wary about overloading for this reason, but it's a key point of the
StringPiece class.

+                          &result.status_code))
       result.has_status_code = (100 <= result.status_code &&
                                 result.status_code <= 599);
     if (result.has_status_code && line.length() >= 4 && line[3] == ' ') {
       result.is_complete = true;
     } else if (result.has_status_code && line.length() >= 4 && line[3] == '-') {
       result.is_complete = true;
       result.is_multiline = true;
     }
   }
 
@@ skipping 13 matching lines @@
   for (size_t i = 0; i < buffer_.length(); i++) {
     if (i >= 1 && buffer_[i - 1] == '\r' && buffer_[i] == '\n') {
       lines_.push(ParseLine(buffer_.substr(cut_pos, i - cut_pos - 1)));
       cut_pos = i + 1;
     }
   }
   buffer_.erase(0, cut_pos);
 }
 
 }  // namespace net