Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 8919026: Remove psutil from tree, install via install-build-deps.sh (Closed)

Created:
9 years ago by DaleCurtis
Modified:
9 years ago
Reviewers:
cmp, Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove psutil from tree, install via install-build-deps.sh Per discussion with thakis, cmp we should remove this dep from the tree and instead install it via install-build-deps.sh. BUG=106105 TEST=Installed dep, ran tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114146

Patch Set 1 #

Total comments: 4

Patch Set 2 : Move to dev_list. #

Total comments: 2

Patch Set 3 : Sort package list. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14832 lines) Patch
M build/install-build-deps.sh View 1 2 1 chunk +11 lines, -11 lines 0 comments Download
D third_party/psutil/CREDITS View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/psutil/HISTORY View 1 chunk +0 lines, -247 lines 0 comments Download
D third_party/psutil/LICENSE View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/psutil/MANIFEST.in View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/psutil/PKG-INFO View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/psutil/README View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/psutil/README.chromium View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/psutil/docs/BUILDING.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D third_party/psutil/docs/class_diagram.dia View 1 chunk +0 lines, -1475 lines 0 comments Download
D third_party/psutil/docs/class_diagram.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/psutil/docs/documentation.html View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/psutil/docs/index.html View 1 2 1 chunk +0 lines, -125 lines 0 comments Download
D third_party/psutil/docs/milestones.lnk.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/psutil/examples/disk_usage.py View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/psutil/examples/iotop.py View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/psutil/examples/killall.py View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/psutil/examples/process_detail.py View 1 chunk +0 lines, -122 lines 0 comments Download
D third_party/psutil/psutil/__init__.py View 1 chunk +0 lines, -822 lines 0 comments Download
D third_party/psutil/psutil/_common.py View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/psutil/psutil/_compat.py View 1 chunk +0 lines, -154 lines 0 comments Download
D third_party/psutil/psutil/_psbsd.py View 1 chunk +0 lines, -230 lines 0 comments Download
D third_party/psutil/psutil/_pslinux.py View 1 chunk +0 lines, -751 lines 0 comments Download
D third_party/psutil/psutil/_psmswindows.py View 1 chunk +0 lines, -293 lines 0 comments Download
D third_party/psutil/psutil/_psosx.py View 1 chunk +0 lines, -233 lines 0 comments Download
D third_party/psutil/psutil/_psposix.py View 1 chunk +0 lines, -318 lines 0 comments Download
D third_party/psutil/psutil/_psutil_bsd.h View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/psutil/psutil/_psutil_bsd.c View 1 chunk +0 lines, -959 lines 0 comments Download
D third_party/psutil/psutil/_psutil_common.h View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/psutil/psutil/_psutil_common.c View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/psutil/psutil/_psutil_linux.h View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/psutil/psutil/_psutil_linux.c View 1 chunk +0 lines, -211 lines 0 comments Download
D third_party/psutil/psutil/_psutil_mswindows.h View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/psutil/psutil/_psutil_mswindows.c View 1 chunk +0 lines, -1897 lines 0 comments Download
D third_party/psutil/psutil/_psutil_osx.h View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/psutil/psutil/_psutil_osx.c View 1 chunk +0 lines, -1430 lines 0 comments Download
D third_party/psutil/psutil/_psutil_posix.h View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/psutil/psutil/_psutil_posix.c View 1 chunk +0 lines, -134 lines 0 comments Download
D third_party/psutil/psutil/arch/bsd/process_info.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/psutil/psutil/arch/bsd/process_info.c View 1 chunk +0 lines, -270 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/ntextapi.h View 1 chunk +0 lines, -183 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/process_handles.h View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/process_handles.c View 1 chunk +0 lines, -304 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/process_info.h View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/process_info.c View 1 chunk +0 lines, -490 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/security.h View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/psutil/psutil/arch/mswindows/security.c View 1 2 1 chunk +0 lines, -240 lines 0 comments Download
D third_party/psutil/psutil/arch/osx/process_info.h View 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/psutil/psutil/arch/osx/process_info.c View 1 chunk +0 lines, -254 lines 0 comments Download
D third_party/psutil/psutil/error.py View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/psutil/setup.py View 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/psutil/test/_bsd.py View 1 chunk +0 lines, -165 lines 0 comments Download
D third_party/psutil/test/_linux.py View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/psutil/test/_osx.py View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/psutil/test/_posix.py View 1 chunk +0 lines, -148 lines 0 comments Download
D third_party/psutil/test/_windows.py View 1 chunk +0 lines, -189 lines 0 comments Download
D third_party/psutil/test/test_memory_leaks.py View 1 chunk +0 lines, -211 lines 0 comments Download
D third_party/psutil/test/test_psutil.py View 1 chunk +0 lines, -1493 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
DaleCurtis
PTAL. Follow up from http://codereview.chromium.org/8774018/
9 years ago (2011-12-13 00:00:25 UTC) #1
Nico
I like this much better :-) Be sure to inform the infra guys that this ...
9 years ago (2011-12-13 00:05:31 UTC) #2
DaleCurtis
http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh#newcode141 build/install-build-deps.sh:141: plugin_list="flashplugin-installer python-psutil" On 2011/12/13 00:05:31, Nico wrote: > plugin_list ...
9 years ago (2011-12-13 00:06:56 UTC) #3
Nico
http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh#newcode141 build/install-build-deps.sh:141: plugin_list="flashplugin-installer python-psutil" On 2011/12/13 00:06:56, DaleCurtis wrote: > They ...
9 years ago (2011-12-13 00:10:35 UTC) #4
DaleCurtis
http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8919026/diff/1/build/install-build-deps.sh#newcode141 build/install-build-deps.sh:141: plugin_list="flashplugin-installer python-psutil" Fair enough :) Done. On 2011/12/13 00:10:35, ...
9 years ago (2011-12-13 00:12:42 UTC) #5
Nico
LGTM, thanks! http://codereview.chromium.org/8919026/diff/6001/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8919026/diff/6001/build/install-build-deps.sh#newcode115 build/install-build-deps.sh:115: libcurl4-gnutls-dev ttf-indic-fonts ttf-thai-tlwg python-psutil nit: It looks ...
9 years ago (2011-12-13 00:14:06 UTC) #6
DaleCurtis
http://codereview.chromium.org/8919026/diff/6001/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8919026/diff/6001/build/install-build-deps.sh#newcode115 build/install-build-deps.sh:115: libcurl4-gnutls-dev ttf-indic-fonts ttf-thai-tlwg python-psutil On 2011/12/13 00:14:06, Nico wrote: ...
9 years ago (2011-12-13 00:35:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/8919026/4002
9 years ago (2011-12-13 00:35:15 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-13 01:42:51 UTC) #9
Change committed as 114146

Powered by Google App Engine
This is Rietveld 408576698