Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 8919024: Aura: Move print_dialog_cloud_uitests back to browser_tests (Closed)

Created:
9 years ago by oshima
Modified:
9 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Aura: Move print_dialog_cloud_uitests back to browser_tests This basically a revert of r112435 except that the test remains active. original CL: http://codereview.chromium.org/8735016 BUG=103497 TEST=browser_tests should stay green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114174

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
9 years ago (2011-12-13 01:27:29 UTC) #1
Lei Zhang
lgtm
9 years ago (2011-12-13 01:49:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8919024/5
9 years ago (2011-12-13 01:59:16 UTC) #3
commit-bot: I haz the power
Change committed as 114174
9 years ago (2011-12-13 03:35:37 UTC) #4
Peter Mayo
On 2011/12/13 03:35:37, I haz the power (commit-bot) wrote: > Change committed as 114174 Looks ...
9 years ago (2011-12-13 05:07:51 UTC) #5
oshima
9 years ago (2011-12-13 05:23:12 UTC) #6
Yes, seems like this needs to be in interactive_ui_tests. I'll move it back.

On Mon, Dec 12, 2011 at 9:07 PM, <petermayo@chromium.org> wrote:

> On 2011/12/13 03:35:37, I haz the power (commit-bot) wrote:
>
>> Change committed as 114174
>>
>
> Looks like this fails.
>
> /chromium.chromiumos/builders/**Linux%20ChromeOS%20Aura/**
> builds/1773/steps/browser_**tests/logs/HandlersRegistered
>
>
http://codereview.chromium.**org/8919024/<http://codereview.chromium.org/8919...
>

Powered by Google App Engine
This is Rietveld 408576698