Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 8735016: Move print_dialog_cloud_uitests to interactive_ui_tests for troubleshooting for aura (Closed)

Created:
9 years ago by oshima
Modified:
9 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move print_dialog_cloud_uitests to interactive_ui_tests for troubleshooting for aura. Move the test to interactive_ui_tests to keep browser_test green while troubleshooting the issue for aura. This may actually be necessary as it's using SendKey functions. (no other tests in browser_tests uses it and all other tests that uses SendKey/Events are in interative_ui_tests) BUG=103497 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112435

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/printing/print_dialog_cloud_uitest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
9 years ago (2011-11-30 01:52:09 UTC) #1
Emmanuel Saint-loubert-Bié
lgtm
9 years ago (2011-11-30 02:03:04 UTC) #2
Lei Zhang
should be fine, but I'll let Albert give the final lg since he's more familiar ...
9 years ago (2011-11-30 02:08:20 UTC) #3
oshima
Just to be clear. This change is for aura only.
9 years ago (2011-11-30 02:22:58 UTC) #4
Albert Bodenhamer
lgtm It looks as though your try jobs all failed early. Please re-run them before ...
9 years ago (2011-11-30 20:10:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8735016/6001
9 years ago (2011-11-30 23:44:20 UTC) #6
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
9 years ago (2011-12-01 02:30:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8735016/6001
9 years ago (2011-12-01 08:33:13 UTC) #8
commit-bot: I haz the power
9 years ago (2011-12-01 09:35:05 UTC) #9
Change committed as 112435

Powered by Google App Engine
This is Rietveld 408576698