This fixes a bug I introduced last night

This fixes a bug I introduced last night with
fetching the default nickname.

BUG=none
TEST=imported user certs successfully.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114150

[Greg Spencer (Chromium), 2011-12-12 22:37:16]

A very small change to avoid crashing when importing user certs.

I should have found this before checking in, but I was focusing on server and ca
certs and forgot to check importing user certs after my change to get the
nickname from the private key (I was relying on the unit tests too much!)

[wtc, 2011-12-12 23:52:57]

LGTM.

http://codereview.chromium.org/8919020/diff/1/net/base/x509_certificate_nss.cc
File net/base/x509_certificate_nss.cc (right):

http://codereview.chromium.org/8919020/diff/1/net/base/x509_certificate_nss.c...
net/base/x509_certificate_nss.cc:717: if (cert_handle_->slot) {

You can merge lines 713 and 717:
  if (type == USER_CERT && cert_handle_->slot) {

So the reason for the crash is that cert_handle_->slot may be
NULL for user certs?

[Greg Spencer (Chromium), 2011-12-13 00:20:14]

On 2011/12/12 23:52:57, wtc wrote:
> You can merge lines 713 and 717:
>   if (type == USER_CERT && cert_handle_->slot) {

Done.

> So the reason for the crash is that cert_handle_->slot may be
> NULL for user certs?

Yes, that's the reason.

[wtc, 2011-12-13 00:28:41]

Patch Set 2 LGTM.

[commit-bot: I haz the power, 2011-12-13 00:37:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gspencer@chromium.org/8919020/4001

[commit-bot: I haz the power, 2011-12-13 01:52:37]

Change committed as 114150