This fixes a bug I introduced last night

net/base/x509_certificate_nss.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/x509_certificate.h"
 
 #include <cert.h>
 #include <cryptohi.h>
 #include <keyhi.h>
 #include <nss.h>
@@ skipping 696 matching lines @@
 
 std::string X509Certificate::GetDefaultNickname(CertType type) const {
   if (!default_nickname_.empty())
     return default_nickname_;
 
   std::string result;
   if (type == USER_CERT) {
     // Find the private key for this certificate and see if it has a
     // nickname.  If there is a private key, and it has a nickname, then
     // we return that nickname.
-    SECKEYPrivateKey* private_key = PK11_FindPrivateKeyFromCert(
-        cert_handle_->slot,
-        cert_handle_,
-        NULL);  // wincx
-    if (private_key) {
-      char* private_key_nickname = PK11_GetPrivateKeyNickname(private_key);
-      if (private_key_nickname) {
-        result = private_key_nickname;
-        PORT_Free(private_key_nickname);
+    if (cert_handle_->slot) {

[wtc, 2011/12/12 23:52:57]

You can merge lines 713 and 717:
  if (type == USER_CERT && cert_handle_->slot) {

So the reason for the crash is that cert_handle_->slot may be
NULL for user certs?

+      SECKEYPrivateKey* private_key = PK11_FindPrivateKeyFromCert(
+          cert_handle_->slot,
+          cert_handle_,
+          NULL);  // wincx
+      if (private_key) {
+        char* private_key_nickname = PK11_GetPrivateKeyNickname(private_key);
+        if (private_key_nickname) {
+          result = private_key_nickname;
+          PORT_Free(private_key_nickname);
+          SECKEY_DestroyPrivateKey(private_key);
+          return result;
+        }
         SECKEY_DestroyPrivateKey(private_key);
-        return result;
       }
-      SECKEY_DestroyPrivateKey(private_key);
     }
   }
 
   switch (type) {
     case CA_CERT: {
       char* nickname = CERT_MakeCANickname(cert_handle_);
       result = nickname;
       PORT_Free(nickname);
       break;
     }
@@ skipping 396 matching lines @@
 
 // static
 bool X509Certificate::WriteOSCertHandleToPickle(OSCertHandle cert_handle,
                                                 Pickle* pickle) {
   return pickle->WriteData(
       reinterpret_cast<const char*>(cert_handle->derCert.data),
       cert_handle->derCert.len);
 }
 
 }  // namespace net