chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Version for commit (merged again). Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_menu_controller_views.cc ('k') | chrome/browser/ui/views/critical_notification_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

index cfac24a24c5bde20a981446caca1e73f72ed8b33..9ca672b0b89dcdfbde738ea79eed9022c24bb6e4 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

@@ -14,7 +14,7 @@

#include "chrome/browser/ui/views/event_utils.h"

#include "chrome/common/pref_names.h"

#include "content/browser/tab_contents/page_navigator.h"

-#include "content/browser/user_metrics.h"

+#include "content/public/browser/user_metrics.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "grit/ui_resources.h"

@@ -26,6 +26,7 @@

#include "ui/views/controls/menu/submenu_view.h"

#include "ui/views/widget/widget.h"

+using content::UserMetricsAction;

using views::MenuItemView;

// Max width of a menu. There does not appear to be an OS value for this, yet

@@ -288,7 +289,7 @@ void BookmarkMenuDelegate::WriteDragData(MenuItemView* sender,

ui::OSExchangeData* data) {

DCHECK(sender && data);

- UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_DragFromFolder"));

+ content::RecordAction(UserMetricsAction("BookmarkBar_DragFromFolder"));

BookmarkNodeData drag_data(menu_id_to_node_map_[sender->GetCommand()]);

drag_data.Write(profile_, data);