Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/bookmarks/bookmark_model.h" 8 #include "chrome/browser/bookmarks/bookmark_model.h"
9 #include "chrome/browser/bookmarks/bookmark_node_data.h" 9 #include "chrome/browser/bookmarks/bookmark_node_data.h"
10 #include "chrome/browser/bookmarks/bookmark_utils.h" 10 #include "chrome/browser/bookmarks/bookmark_utils.h"
11 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" 13 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
14 #include "chrome/browser/ui/views/event_utils.h" 14 #include "chrome/browser/ui/views/event_utils.h"
15 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
16 #include "content/browser/tab_contents/page_navigator.h" 16 #include "content/browser/tab_contents/page_navigator.h"
17 #include "content/browser/user_metrics.h" 17 #include "content/public/browser/user_metrics.h"
18 #include "grit/generated_resources.h" 18 #include "grit/generated_resources.h"
19 #include "grit/theme_resources.h" 19 #include "grit/theme_resources.h"
20 #include "grit/ui_resources.h" 20 #include "grit/ui_resources.h"
21 #include "ui/base/dragdrop/os_exchange_data.h" 21 #include "ui/base/dragdrop/os_exchange_data.h"
22 #include "ui/base/l10n/l10n_util.h" 22 #include "ui/base/l10n/l10n_util.h"
23 #include "ui/base/resource/resource_bundle.h" 23 #include "ui/base/resource/resource_bundle.h"
24 #include "ui/views/controls/button/menu_button.h" 24 #include "ui/views/controls/button/menu_button.h"
25 #include "ui/views/controls/menu/menu_item_view.h" 25 #include "ui/views/controls/menu/menu_item_view.h"
26 #include "ui/views/controls/menu/submenu_view.h" 26 #include "ui/views/controls/menu/submenu_view.h"
27 #include "ui/views/widget/widget.h" 27 #include "ui/views/widget/widget.h"
28 28
29 using content::UserMetricsAction;
29 using views::MenuItemView; 30 using views::MenuItemView;
30 31
31 // Max width of a menu. There does not appear to be an OS value for this, yet 32 // Max width of a menu. There does not appear to be an OS value for this, yet
32 // both IE and FF restrict the max width of a menu. 33 // both IE and FF restrict the max width of a menu.
33 static const int kMaxMenuWidth = 400; 34 static const int kMaxMenuWidth = 400;
34 35
35 BookmarkMenuDelegate::BookmarkMenuDelegate(Profile* profile, 36 BookmarkMenuDelegate::BookmarkMenuDelegate(Profile* profile,
36 PageNavigator* navigator, 37 PageNavigator* navigator,
37 views::Widget* parent, 38 views::Widget* parent,
38 int first_menu_id) 39 int first_menu_id)
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 bool BookmarkMenuDelegate::CanDrag(MenuItemView* menu) { 282 bool BookmarkMenuDelegate::CanDrag(MenuItemView* menu) {
282 const BookmarkNode* node = menu_id_to_node_map_[menu->GetCommand()]; 283 const BookmarkNode* node = menu_id_to_node_map_[menu->GetCommand()];
283 // Don't let users drag the other folder. 284 // Don't let users drag the other folder.
284 return node->parent() != profile_->GetBookmarkModel()->root_node(); 285 return node->parent() != profile_->GetBookmarkModel()->root_node();
285 } 286 }
286 287
287 void BookmarkMenuDelegate::WriteDragData(MenuItemView* sender, 288 void BookmarkMenuDelegate::WriteDragData(MenuItemView* sender,
288 ui::OSExchangeData* data) { 289 ui::OSExchangeData* data) {
289 DCHECK(sender && data); 290 DCHECK(sender && data);
290 291
291 UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_DragFromFolder")); 292 content::RecordAction(UserMetricsAction("BookmarkBar_DragFromFolder"));
292 293
293 BookmarkNodeData drag_data(menu_id_to_node_map_[sender->GetCommand()]); 294 BookmarkNodeData drag_data(menu_id_to_node_map_[sender->GetCommand()]);
294 drag_data.Write(profile_, data); 295 drag_data.Write(profile_, data);
295 } 296 }
296 297
297 int BookmarkMenuDelegate::GetDragOperations(MenuItemView* sender) { 298 int BookmarkMenuDelegate::GetDragOperations(MenuItemView* sender) {
298 return bookmark_utils::BookmarkDragOperation( 299 return bookmark_utils::BookmarkDragOperation(
299 profile_, menu_id_to_node_map_[sender->GetCommand()]); 300 profile_, menu_id_to_node_map_[sender->GetCommand()]);
300 } 301 }
301 302
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 MenuItemView* BookmarkMenuDelegate::GetMenuByID(int id) { 476 MenuItemView* BookmarkMenuDelegate::GetMenuByID(int id) {
476 for (NodeToMenuMap::const_iterator i = node_to_menu_map_.begin(); 477 for (NodeToMenuMap::const_iterator i = node_to_menu_map_.begin();
477 i != node_to_menu_map_.end(); ++i) { 478 i != node_to_menu_map_.end(); ++i) {
478 MenuItemView* menu = i->second->GetMenuItemByID(id); 479 MenuItemView* menu = i->second->GetMenuItemByID(id);
479 if (menu) 480 if (menu)
480 return menu; 481 return menu;
481 } 482 }
482 483
483 return parent_menu_item_ ? parent_menu_item_->GetMenuItemByID(id) : NULL; 484 return parent_menu_item_ ? parent_menu_item_->GetMenuItemByID(id) : NULL;
484 } 485 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698