chrome/browser/ui/search_engines/keyword_editor_controller.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/keyword_editor_controller.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Version for commit (merged again). Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search_engines/edit_search_engine_controller.cc ('k') | chrome/browser/ui/toolbar/back_forward_menu_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/keyword_editor_controller.cc

diff --git a/chrome/browser/ui/search_engines/keyword_editor_controller.cc b/chrome/browser/ui/search_engines/keyword_editor_controller.cc

index 97752aadc1de3cb30be120905279fa3af3de0d6c..e160655cae29674b19c4acdc1eb1eac05657d05a 100644

--- a/chrome/browser/ui/search_engines/keyword_editor_controller.cc

+++ b/chrome/browser/ui/search_engines/keyword_editor_controller.cc

@@ -12,7 +12,9 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/ui/search_engines/template_url_table_model.h"

#include "chrome/common/pref_names.h"

-#include "content/browser/user_metrics.h"

+#include "content/public/browser/user_metrics.h"

+using content::UserMetricsAction;

KeywordEditorController::KeywordEditorController(Profile* profile)

: profile_(profile) {

@@ -35,7 +37,7 @@ int KeywordEditorController::AddTemplateURL(const string16& title,

const std::string& url) {

DCHECK(!url.empty());

- UserMetrics::RecordAction(UserMetricsAction("KeywordEditor_AddKeyword"));

+ content::RecordAction(UserMetricsAction("KeywordEditor_AddKeyword"));

TemplateURL* template_url = new TemplateURL();

template_url->set_short_name(title);

@@ -75,7 +77,7 @@ void KeywordEditorController::ModifyTemplateURL(const TemplateURL* template_url,

table_model_->ModifyTemplateURL(index, title, keyword, url);

- UserMetrics::RecordAction(UserMetricsAction("KeywordEditor_ModifiedKeyword"));

+ content::RecordAction(UserMetricsAction("KeywordEditor_ModifiedKeyword"));

}

bool KeywordEditorController::CanEdit(const TemplateURL* url) const {

@@ -93,7 +95,7 @@ bool KeywordEditorController::CanRemove(const TemplateURL* url) const {

void KeywordEditorController::RemoveTemplateURL(int index) {

table_model_->Remove(index);

- UserMetrics::RecordAction(UserMetricsAction("KeywordEditor_RemoveKeyword"));

+ content::RecordAction(UserMetricsAction("KeywordEditor_RemoveKeyword"));

}

int KeywordEditorController::MakeDefaultTemplateURL(int index) {