chrome/browser/ui/search_engines/edit_search_engine_controller.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Version for commit (merged again). Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/search_engines/keyword_editor_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/edit_search_engine_controller.cc

diff --git a/chrome/browser/ui/search_engines/edit_search_engine_controller.cc b/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

index a0c9b52bf07fb1de02009b939c8413dc0215ac51..4716d37af43ade82cfbb3c33871cf3a30c523d04 100644

--- a/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

+++ b/chrome/browser/ui/search_engines/edit_search_engine_controller.cc

@@ -11,9 +11,11 @@

#include "chrome/browser/search_engines/template_url.h"

#include "chrome/browser/search_engines/template_url_service.h"

#include "chrome/browser/search_engines/template_url_service_factory.h"

-#include "content/browser/user_metrics.h"

+#include "content/public/browser/user_metrics.h"

#include "googleurl/src/gurl.h"

+using content::UserMetricsAction;

EditSearchEngineController::EditSearchEngineController(

const TemplateURL* template_url,

EditSearchEngineControllerDelegate* edit_keyword_delegate,

@@ -104,7 +106,7 @@ void EditSearchEngineController::AcceptAddOrEdit(

modifiable_url->SetURL(url_string, 0, 0);

// TemplateURLService takes ownership of template_url_.

template_url_service->Add(modifiable_url);

- UserMetrics::RecordAction(UserMetricsAction("KeywordEditor_AddKeywordJS"));

+ content::RecordAction(UserMetricsAction("KeywordEditor_AddKeywordJS"));

} else {

// Adding or modifying an entry via the Delegate.

edit_keyword_delegate_->OnEditedKeyword(template_url_,

« no previous file with comments | « chrome/browser/ui/pdf/pdf_unsupported_feature.cc ('k') | chrome/browser/ui/search_engines/keyword_editor_controller.cc » ('j') | no next file with comments »