Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Version for commit (merged again). Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
index 10397ca7e98301bb08282594ee8760f71c73059c..7ad1399b07c405bd31f901f4f2927eabf3ced9f3 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
@@ -12,13 +12,15 @@
#import "chrome/browser/ui/cocoa/bookmarks/bookmark_cell_single_line.h"
#import "chrome/browser/ui/cocoa/browser_window_controller.h"
#import "chrome/browser/ui/cocoa/info_bubble_view.h"
-#include "content/browser/user_metrics.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/notification_service.h"
+#include "content/public/browser/user_metrics.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util_mac.h"
+using content::UserMetricsAction;
+
// Simple class to watch for tab creation/destruction and close the bubble.
// Bridge between Chrome-style notifications and ObjC-style notifications.
@@ -264,7 +266,7 @@ void BookmarkBubbleNotificationBridge::Observe(
}
- (IBAction)edit:(id)sender {
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Edit"));
[self showEditor];
}
@@ -289,7 +291,7 @@ void BookmarkBubbleNotificationBridge::Observe(
- (IBAction)remove:(id)sender {
[self stopPulsingBookmarkButton];
bookmark_utils::RemoveAllBookmarks(model_, node_->url());
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_Unstar"));
node_ = NULL; // no longer valid
[self ok:sender];
}
@@ -306,7 +308,7 @@ void BookmarkBubbleNotificationBridge::Observe(
NSMenuItem* selected = [folderPopUpButton_ selectedItem];
ChooseAnotherFolder* chooseItem = [[self class] chooseAnotherFolderObject];
if ([[selected representedObject] isEqual:chooseItem]) {
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_EditFromCombobox"));
[self showEditor];
}
@@ -335,7 +337,7 @@ void BookmarkBubbleNotificationBridge::Observe(
NSString* newTitle = [nameTextField_ stringValue];
if (![oldTitle isEqual:newTitle]) {
model_->SetTitle(node_, base::SysNSStringToUTF16(newTitle));
- UserMetrics::RecordAction(
+ content::RecordAction(
UserMetricsAction("BookmarkBubble_ChangeTitleInBubble"));
}
// Then the parent folder.
@@ -352,7 +354,7 @@ void BookmarkBubbleNotificationBridge::Observe(
if (oldParent != newParent) {
int index = newParent->child_count();
model_->Move(node_, newParent, index);
- UserMetrics::RecordAction(UserMetricsAction("BookmarkBubble_ChangeParent"));
+ content::RecordAction(UserMetricsAction("BookmarkBubble_ChangeParent"));
}
}
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698