chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Version for commit (merged again). Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_view.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm

index e0e6614e82380402bd3c4ee5ccb69fe2b27a956e..0f519cb3ced6e314d1c2cd31c1c2f2403901fefd 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view.mm

@@ -6,16 +6,18 @@

#include "chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h"

#include "chrome/browser/profiles/profile.h"

+#import "chrome/browser/themes/theme_service.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_button.h"

#import "chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h"

#import "chrome/browser/ui/cocoa/browser_window_controller.h"

#import "chrome/browser/ui/cocoa/themed_window.h"

#import "chrome/browser/ui/cocoa/view_id_util.h"

-#import "chrome/browser/themes/theme_service.h"

-#include "content/browser/user_metrics.h"

+#include "content/public/browser/user_metrics.h"

#import "third_party/mozilla/NSPasteboard+Utils.h"

+using content::UserMetricsAction;

@interface BookmarkBarView (Private)

- (void)themeDidChangeNotification:(NSNotification*)aNotification;

- (void)updateTheme:(ui::ThemeProvider*)themeProvider;

@@ -242,7 +244,7 @@

rtn = [controller_ dragButton:button

to:[info draggingLocation]

copy:copy];

- UserMetrics::RecordAction(UserMetricsAction("BookmarkBar_DragEnd"));

+ content::RecordAction(UserMetricsAction("BookmarkBar_DragEnd"));

}

return rtn;

}