chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/fullscreen_controller.cc ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc » ('j') | content/browser/user_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

index dade1abee6e930f30655e9191b7482c833966fdf..443623b0d101553c9949af3dee1795e16a10df7a 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc

@@ -36,9 +36,9 @@

#include "chrome/common/pref_names.h"

#include "content/browser/tab_contents/tab_contents.h"

#include "content/browser/tab_contents/tab_contents_view.h"

-#include "content/browser/user_metrics.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

+#include "content/public/browser/user_metrics.h"

#include "grit/generated_resources.h"

#include "grit/theme_resources.h"

#include "grit/ui_resources.h"

@@ -50,6 +50,8 @@

#include "ui/gfx/image/cairo_cached_surface.h"

#include "ui/gfx/image/image.h"

+using content::UserMetricsAction;

namespace {

// The showing height of the bar.

@@ -1134,7 +1136,7 @@ void BookmarkBarGtk::OnClicked(GtkWidget* sender) {

bookmark_utils::OpenAll(window_->GetNativeHandle(), profile, page_navigator_,

node, gtk_util::DispositionForCurrentButtonPressEvent());

- UserMetrics::RecordAction(UserMetricsAction("ClickedBookmarkBarURLButton"));

+ content::RecordAction(UserMetricsAction("ClickedBookmarkBarURLButton"));

}

void BookmarkBarGtk::OnButtonDragBegin(GtkWidget* button,

« no previous file with comments | « chrome/browser/ui/fullscreen_controller.cc ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc » ('j') | content/browser/user_metrics.cc » ('J')