chrome/browser/ui/fullscreen_controller.cc - Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/fullscreen_controller.cc

Issue 8919017: Split UserMetrics into API vs. implementation. Move API to content/public. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move to content namespace. Update usages. Update extract_actions tool. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_bubble_model.cc ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc » ('j') | content/browser/user_metrics.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/fullscreen_controller.cc

diff --git a/chrome/browser/ui/fullscreen_controller.cc b/chrome/browser/ui/fullscreen_controller.cc

index c8f497e59b2bb8d24b3e3c6880a69bd65321b190..e15a2492f74b0bb374b1b05ece24656cf76ec4f8 100644

--- a/chrome/browser/ui/fullscreen_controller.cc

+++ b/chrome/browser/ui/fullscreen_controller.cc

@@ -14,8 +14,10 @@

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

#include "content/browser/renderer_host/render_view_host.h"

-#include "content/browser/user_metrics.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/browser/user_metrics.h"

+using content::UserMetricsAction;

FullscreenController::FullscreenController(BrowserWindow* window,

Profile* profile,

@@ -165,7 +167,7 @@ void FullscreenController::ToggleFullscreenMode(bool for_tab) {

tab_fullscreen_accepted_ = entering_fullscreen &&

GetFullscreenSetting(url) == CONTENT_SETTING_ALLOW;

} else {

- UserMetrics::RecordAction(UserMetricsAction("ToggleFullscreen"));

+ content::RecordAction(UserMetricsAction("ToggleFullscreen"));

}

if (entering_fullscreen)

window_->EnterFullscreen(url, GetFullscreenExitBubbleType());