Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 8918029: Silence a (spurious) use after free message (Closed)

Created:
9 years ago by groby-ooo-7-16
Modified:
9 years ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke, szym
Visibility:
Public.

Description

Silence a (spurious) use after free message BUG=none TEST=AsyncHostResolver.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/dns/async_host_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
groby-ooo-7-16
Reordered std::list::remove and delete so static analysers don't think we use pointer after free
9 years ago (2011-12-13 00:58:26 UTC) #1
wtc
LGTM. Please add "Coverity" to the CL's commit message. szym: just FYI.
9 years ago (2011-12-13 01:05:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8918029/1
9 years ago (2011-12-13 04:45:33 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-13 06:25:33 UTC) #4
Change committed as 114186

Powered by Google App Engine
This is Rietveld 408576698