net/dns/async_host_resolver.cc - Issue 8918029: Silence a (spurious) use after free message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/async_host_resolver.cc

Issue 8918029: Silence a (spurious) use after free message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/async_host_resolver.cc

diff --git a/net/dns/async_host_resolver.cc b/net/dns/async_host_resolver.cc

index ff93c3e52f794bc09719bbda2179e43a8f96ba97..6f6552bcfa684a7c680c9076ef19733c45e9918c 100644

--- a/net/dns/async_host_resolver.cc

+++ b/net/dns/async_host_resolver.cc

@@ -397,8 +397,8 @@ void AsyncHostResolver::OnDnsRequestComplete(

requestlist_map_.erase(rit);

// Cleanup |dns_req| and start a new one if there are pending requests.

- delete dns_req;

dns_requests_.remove(dns_req);

+ delete dns_req;

ProcessPending();

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »