Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 8917011: Change signature of |ui::ElideText()|. Add a truncate mode. (Closed)

Created:
9 years ago by Alexei Svitkine (slow)
Modified:
9 years ago
Reviewers:
sky
CC:
chromium-reviews, asanka, sadrul, tfarina, dhollowa+watch_chromium.org, ben+watch_chromium.org, Randy Smith (Not in Mondays), Paweł Hajdan Jr., James Su
Visibility:
Public.

Description

Change signature of |ui::ElideText()|. Add a truncate mode. The new truncate mode is needed by my upcoming changes to rewrite CanvasSkia::DrawText(). Part of the change is changing the binary search code to a more traditional form that also makes the truncate mode work correctly. This is covered by the new unit tests. BUG=105550 TEST=New and existing tests in text_elider_unittest.cc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114063

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -45 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/ev_bubble_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/avatar_menu_item_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/content_setting_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/print_settings_initializer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/aura_shell/shell_tooltip_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/text/text_elider.h View 1 chunk +12 lines, -4 lines 0 comments Download
M ui/base/text/text_elider.cc View 12 chunks +25 lines, -18 lines 0 comments Download
M ui/base/text/text_elider_unittest.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M ui/views/controls/label.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/tooltip_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
9 years ago (2011-12-12 16:52:24 UTC) #1
sky
LGTM
9 years ago (2011-12-12 17:25:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8917011/5014
9 years ago (2011-12-12 19:23:16 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-12 19:23:20 UTC) #4
Can't process patch for file
chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698