chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm - Issue 8917011: Change signature of |ui::ElideText()|. Add a truncate mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

Issue 8917011: Change signature of |ui::ElideText()|. Add a truncate mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm

===================================================================

--- chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm (revision 114022)

+++ chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac_unittest.mm (working copy)

@@ -461,14 +461,14 @@

// When elided, result is the same as ElideText().

ret = OmniboxPopupViewMac::ElideString(as, contents16, font_, kNarrow);

- string16 elided = ui::ElideText(contents16, font_, kNarrow, false);

+ string16 elided = ui::ElideText(contents16, font_, kNarrow, ui::ELIDE_AT_END);

EXPECT_TRUE(ret == as);

EXPECT_FALSE([[as string] isEqualToString:contents]);

EXPECT_TRUE([[as string] isEqualToString:base::SysUTF16ToNSString(elided)]);

// When elided, result is the same as ElideText().

ret = OmniboxPopupViewMac::ElideString(as, contents16, font_, 0.0);

- elided = ui::ElideText(contents16, font_, 0.0, false);

+ elided = ui::ElideText(contents16, font_, 0.0, ui::ELIDE_AT_END);

EXPECT_TRUE(ret == as);

EXPECT_FALSE([[as string] isEqualToString:contents]);

EXPECT_TRUE([[as string] isEqualToString:base::SysUTF16ToNSString(elided)]);