Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 8916005: add -fPIC to ldflags if linux_fpic is enabled (Closed)

Created:
9 years ago by Robert Nagy
Modified:
9 years ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

add -fPIC to ldflags if linux_fpic is enabled BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Nagy
9 years ago (2011-12-14 17:45:32 UTC) #1
Mark Mentovai
LGTM
9 years ago (2011-12-14 18:00:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8916005/1
9 years ago (2011-12-14 18:06:00 UTC) #3
commit-bot: I haz the power
9 years ago (2011-12-14 19:04:37 UTC) #4
Change committed as 114467

Powered by Google App Engine
This is Rietveld 408576698