Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: build/common.gypi

Issue 8916005: add -fPIC to ldflags if linux_fpic is enabled (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 1850 matching lines...) Expand 10 before | Expand all | Expand 10 after
1861 ], 1861 ],
1862 }], 1862 }],
1863 ], 1863 ],
1864 }], 1864 }],
1865 ], 1865 ],
1866 }], 1866 }],
1867 ['linux_fpic==1', { 1867 ['linux_fpic==1', {
1868 'cflags': [ 1868 'cflags': [
1869 '-fPIC', 1869 '-fPIC',
1870 ], 1870 ],
1871 'ldflags': [
1872 '-fPIC',
1873 ],
1871 }], 1874 }],
1872 # TODO(rkc): Currently building Chrome with the PIE flag causes 1875 # TODO(rkc): Currently building Chrome with the PIE flag causes
1873 # remote debugging to break (remote debugger does not get correct 1876 # remote debugging to break (remote debugger does not get correct
1874 # section header offsets hence causing all symbol handling to go 1877 # section header offsets hence causing all symbol handling to go
1875 # kaboom). See crosbug.com/15266 1878 # kaboom). See crosbug.com/15266
1876 # Remove this flag once this issue is fixed. 1879 # Remove this flag once this issue is fixed.
1877 ['linux_disable_pie==1', { 1880 ['linux_disable_pie==1', {
1878 'target_conditions': [ 1881 'target_conditions': [
1879 ['_type=="executable"', { 1882 ['_type=="executable"', {
1880 'ldflags': [ 1883 'ldflags': [
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
2664 # settings in target dicts. SYMROOT is a special case, because many other 2667 # settings in target dicts. SYMROOT is a special case, because many other
2665 # Xcode variables depend on it, including variables such as 2668 # Xcode variables depend on it, including variables such as
2666 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 2669 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
2667 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 2670 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
2668 # files to appear (when present) in the UI as actual files and not red 2671 # files to appear (when present) in the UI as actual files and not red
2669 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 2672 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
2670 # and therefore SYMROOT, needs to be set at the project level. 2673 # and therefore SYMROOT, needs to be set at the project level.
2671 'SYMROOT': '<(DEPTH)/xcodebuild', 2674 'SYMROOT': '<(DEPTH)/xcodebuild',
2672 }, 2675 },
2673 } 2676 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698