Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 8914022: Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly. (Closed)

Created:
9 years ago by sail
Modified:
9 years ago
Reviewers:
awong
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, ncarter (slow), akalin, Raghu Simha, ddorwin+watch_chromium.org, fischman+watch_chromium.org, erikwright (departed), rkn, acolwell+watch_chromium.org, annacc+watch_chromium.org, Randy Smith (Not in Mondays), wtc, darin-cc_chromium.org, Paweł Hajdan Jr., vrk (LEFT CHROMIUM), brettw-cc_chromium.org, scherkus (not reviewing), tim (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly. This removes some complexity and also fixes a bug where if you call Bind() with the result of Bind(), the resulting Callback would only be valid during the first call. Ouch. BUG=none TEST=new unittests Review URL: http://codereview.chromium.org/8738001 TBR=ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+280 lines, -341 lines) Patch
M base/bind.h View 11 chunks +76 lines, -93 lines 0 comments Download
M base/bind.h.pump View 2 chunks +7 lines, -10 lines 0 comments Download
M base/bind_unittest.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M base/callback.h View 9 chunks +105 lines, -93 lines 0 comments Download
M base/callback.h.pump View 3 chunks +28 lines, -30 lines 0 comments Download
M base/callback_internal.h View 2 chunks +25 lines, -5 lines 0 comments Download
M base/callback_internal.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M base/callback_unittest.cc View 4 chunks +7 lines, -29 lines 0 comments Download
M base/cancelable_callback.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/debug/trace_event.h View 2 chunks +2 lines, -3 lines 0 comments Download
M base/debug/trace_event.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/debug/trace_event_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/demuxer_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/completion_callback.h View 1 chunk +0 lines, -7 lines 0 comments Download
D net/base/completion_callback.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M net/base/cookie_monster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cookie_store_test_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/cookie_store_test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socket_test_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/socket/web_socket_server_socket.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
9 years ago (2011-12-14 21:48:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698