net/spdy/spdy_proxy_client_socket_unittest.cc - Issue 8914022: Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_proxy_client_socket_unittest.cc

Issue 8914022: Revert 114494 - Remove BindStateHolder and have Bind() return a Callback<> object directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_proxy_client_socket_unittest.cc

===================================================================

--- net/spdy/spdy_proxy_client_socket_unittest.cc (revision 114494)

+++ net/spdy/spdy_proxy_client_socket_unittest.cc (working copy)

@@ -1276,8 +1276,8 @@

scoped_refptr<IOBuffer> read_buf(new IOBuffer(kLen1));

ASSERT_EQ(ERR_IO_PENDING,

sock_->Read(read_buf, kLen1,

- base::Bind(&OldCompletionCallbackAdapter,

- &read_callback)));

+ base::Bind(&DeleteSockCallback::Run<int>,

+ base::Unretained(&read_callback))));

scoped_refptr<IOBufferWithSize> write_buf(CreateBuffer(kMsg1, kLen1));

EXPECT_EQ(ERR_IO_PENDING, sock_->Write(write_buf, write_buf->size(),

« no previous file with comments | « net/socket/web_socket_server_socket.cc ('k') | no next file » | no next file with comments »