Issue 8913011: Revert 114133 - Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8913011: Revert 114133 - Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only in... (Closed)

Created:
9 years ago by Vangelis Kokkevis

Modified:
9 years ago

Reviewers:
Vangelis Kokkevis

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 114133 - Revert 114059 - Fixed service side implementation of glTexStorage2DEXT to only initialize the number of levels requirested. Also ClearLevel now uses glTexSubImage2D to clear the level if the texture is immutable. Finally, rearranged the code in doTexSubImage2D to correctly bypass clearing a level if the bitmaps supplied matches the dimensions of the texture level. BUG=106894 Review URL: http://codereview.chromium.org/8872061 Reverting as it may be causing a failure in the XP perf bots: http://build.chromium.org/p/chromium.perf/builders/XP%20Perf%20%28dbg%29/builds/6854 Un-reverting original change. It doesn't seem to have been the cause for the regression. TBR=vangelis@chromium.org Review URL: http://codereview.chromium.org/8905027 TBR=vangelis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114476

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -54 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	8 chunks	+48 lines, -32 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_mock.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	5 chunks	+5 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	9 chunks	+9 lines, -9 lines	0 comments	Download

Total messages: 1 (0 generated)