Fixed service side implementation of glTexStorage2DEXT to only initialize the number of

Fixed service side implementation of glTexStorage2DEXT to only initialize the number of
levels requirested. Also ClearLevel now uses glTexSubImage2D to clear the level if the
texture is immutable.  Finally, rearranged the code in doTexSubImage2D to correctly
bypass clearing a level if the bitmaps supplied matches the dimensions of the texture level.
BUG=106894
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114059

[vangelis, 2011-12-09 09:03:30]

Ready for review. Gregg, can you please have a look?

[greggman, 2011-12-09 20:22:58]

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6787:
texture_manager()->SetLevelCleared(info, target, level);
this SetLevelCleared line should move to line 6775 just after the first
glTexSubImage2D

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7852: level_width = level_width
>> 1;
these need to be level_width = std::max(1, level_width >> 1);

[vangelis, 2011-12-09 22:53:04]

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6787:
texture_manager()->SetLevelCleared(info, target, level);
On 2011/12/09 20:22:58, greggman wrote:
> this SetLevelCleared line should move to line 6775 just after the first
> glTexSubImage2D

Oops, sorry I missed that. But I probably also need it here as well (or at least
for the glTexSubImage2D path)?

[vangelis, 2011-12-12 18:55:40]

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:6787:
texture_manager()->SetLevelCleared(info, target, level);
On 2011/12/09 20:22:58, greggman wrote:
> this SetLevelCleared line should move to line 6775 just after the first
> glTexSubImage2D

Looking at this again, wouldn't calling ClearTextureLevel() at line 6770 take
care of marking the level as cleared?

http://codereview.chromium.org/8872061/diff/1/gpu/command_buffer/service/gles...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7852: level_width = level_width
>> 1;
On 2011/12/09 20:22:58, greggman wrote:
> these need to be level_width = std::max(1, level_width >> 1);

Done.

[greggman, 2011-12-12 19:35:44]

lgtm